-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace typescript #60
Conversation
@segayuu |
I just added warehouse@3 as part of hexo v4 milestone. |
@segayuu |
The purpose of this PR is to set |
38561f9
to
46773b2
Compare
d70896e
to
24fc225
Compare
Do we have updates on this pr? For now I think that hexo-warehouse is the best json db for tiny apps :p |
I think the same @YuJianghao |
24fc225
to
8e8aa31
Compare
This reverts commit b1a4c57.
@hexojs/core |
test/scripts/database.ts
Outdated
const Promise = require('bluebird'); | ||
const sinon = require('sinon'); | ||
const fs = Promise.promisifyAll(require('fs')); | ||
// @ts-nocheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I add @ts-nocheck
to all test files.
This workaround is temporarily. I will update the test code.
@hexojs/core I think we can improve our code more type safely and robustly. However, I think we need more time to do it. Also, I will fix if the current PR has a critical problem. But, IMHO I want to merge this PR once and improve our code step by step. Thank you :) |
package.json
Outdated
}, | ||
"engines": { | ||
"node": ">=14" | ||
"node": ">=14 <18.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a workaround.
The Error [ERR_STREAM_PREMATURE_CLOSE]: Premature close
error occurs with Node 18.6
. I don't know this problem is a bug or a spec change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO we should delete <18.5
before release the new version (5.0.0
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted
# Conflicts: # package.json # src/database.ts
Updated: Merge the |
@hexojs/core |
One of the reasons why warehouse is hardly maintained is that it doesn't understand the type.
However, the warehouse package is too complex to be typed with DefinitelyTyped, and it is quite possible to make typing errors.