Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types/integer): use Number.isInteger for validating a value is an integer or not #148

Merged
merged 1 commit into from
Feb 25, 2023

Conversation

yoshinorin
Copy link
Member

@yoshinorin yoshinorin commented Feb 16, 2023

This PR is fix for TS2362 & TS2322 errors. We are facing TS2362 & TS2322 errors when we run npm run eslint.

> [email protected] preeslint
> npm run clean && npm run build

> [email protected] clean
> tsc -b --clean

> [email protected] build
> tsc -b

Error: src/types/integer.ts(32,9): error TS2362: The left-hand side of an arithmetic operation must be of type 'any', 'number', 'bigint' or an enum type.
Error: src/types/integer.ts(36,5): error TS2322: Type 'unknown' is not assignable to type 'number'.
Error: Process completed with exit code 1.

Thank you :)

@tomap tomap merged commit bc313ce into hexojs:master Feb 25, 2023
@yoshinorin yoshinorin deleted the fix/ts-errors branch February 28, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants