Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(excerpt): use span instead of anchor element for better SEO performance #4627

Merged
merged 1 commit into from
Jan 29, 2021
Merged

fix(excerpt): use span instead of anchor element for better SEO performance #4627

merged 1 commit into from
Jan 29, 2021

Conversation

stevenjoezhang
Copy link
Member

@stevenjoezhang stevenjoezhang commented Jan 29, 2021 •
edited
Loading

What does it do?

Issue resolved: #4626

How to test

git clone -b more https://github.com/hexojs/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@stevenjoezhang stevenjoezhang requested a review from a team January 29, 2021 00:24
@stevenjoezhang stevenjoezhang changed the title fix(excerpt): use span instead of anchor element for better SEO perfo… fix(excerpt): use span instead of anchor element for better SEO performance Jan 29, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.306% when pulling 6e3fede on more into 30f34f5 on master.

@SukkaW
Copy link
Member

SukkaW commented Jan 29, 2021

Notice that might be a Breaking Changes. Although no need for bumping a major version, it is still necessary to mention it in Change Log.

@stevenjoezhang stevenjoezhang merged commit de8814c into master Jan 29, 2021
@stevenjoezhang stevenjoezhang deleted the more branch January 30, 2021 14:56
@SanderSmee SanderSmee mentioned this pull request Aug 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
Breaking Change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[excerpt.js] Use span instead of anchor element for better SEO performance
3 participants
@stevenjoezhang @coveralls @SukkaW