-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support 'disableNunjucks' in front-matter #4518
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SukkaW
reviewed
Sep 4, 2020
SukkaW
reviewed
Sep 4, 2020
lib/hexo/post.js
Outdated
@@ -259,6 +259,9 @@ class Post { | |||
} | |||
} | |||
|
|||
// front-matter overrides renderer's option | |||
disableNunjucks = typeof data.disableNunjucks === 'boolean' ? data.disableNunjucks : disableNunjucks; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be done before checking the renderer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
front-matter should override renderer in this case.
curbengh
force-pushed
the
fm-disable-nunjucks
branch
from
September 5, 2020 01:38
b54311c
to
c6b2691
Compare
SukkaW
approved these changes
Sep 13, 2020
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Requested by #3259 cc @noraj
Although the behavior of
`{{ }}`
(with backtick wrap) is now working as expected since v5, user may want to use{{ }}
without backtick wrap for certain articles (post/page). With this PR, whendisableNunjucks
are disabled globally (default) or through a renderer, user can enable it per article; at the same time, it is also possible to disable it per article even when it is enabled globally.enabling
disableNunjucks
will disable processing of{{ }}
/{% %}
and tag plugins.How to test
Screenshots
Pull request tasks