-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(helpers): call url_for from hexo-util #4447
Conversation
https://github.com/next-theme/hexo-theme-next/blob/test/test/helpers/next-url.js#L16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we replace all this.url_for
in helpers?
we should. updating PR... (Edit) done
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Anyway, is there any this.full_url_for
exists as well? If so, it could be replaced as well.
That's all I found with vscode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What does it do?
doesn't work for me, somehow
url_for()
is not available in thehexo
context. I tried v4.0.0, v4.1.1, v4.2.1 & v5 in Node 12.18How to test
Screenshots
Pull request tasks