Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: simplify code #4409

Closed
wants to merge 1 commit into from
Closed

refactor: simplify code #4409

wants to merge 1 commit into from

Conversation

2997ms
Copy link
Contributor

@2997ms 2997ms commented Jul 8, 2020 •
edited
Loading

What does it do?

How to test

git clone -b BRANCH https://github.com/USER/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@stevenjoezhang
Copy link
Member

Array.prototype.flat requires node.js 12. Pending #4378

SukkaW
SukkaW requested changes Jul 9, 2020
View reviewed changes
Copy link
Member

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node.js 10 hasn't been dropped yet.

https://node.green/#ES2019-features-Array-prototype--flat--flatMap-

@2997ms 2997ms closed this Jul 9, 2020
@curbengh curbengh mentioned this pull request Oct 24, 2021
Merged
2 tasks
@stevenjoezhang
Copy link
Member

Superseded by #4806
@2997ms thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@2997ms @stevenjoezhang @SukkaW