Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore/ci: drop Node.js 8 and add Node.js 14 #4255

Merged
merged 1 commit into from
Apr 27, 2020
Merged

chore/ci: drop Node.js 8 and add Node.js 14 #4255

merged 1 commit into from
Apr 27, 2020

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Apr 21, 2020 •
edited
Loading

What does it do?

Drop Node 8 (#3818) . It has reached EOL since 2019-12-31 and Node 10 is now in Long Term LTS.

Node.js 10.18.1+ will be used after this PR.

How to test

git clone node-10.0 https://github.com/sukkaw/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

This was referenced Apr 21, 2020
Merged
Merged
Closed
Merged
stevenjoezhang
stevenjoezhang previously approved these changes Apr 21, 2020
View reviewed changes
@SukkaW SukkaW requested a review from stevenjoezhang April 21, 2020 14:42
@stevenjoezhang stevenjoezhang linked an issue Apr 22, 2020 that may be closed by this pull request
Drop NodeJs 8 support & Require NodeJs >= 10 #3818
Closed
jiangtj
jiangtj previously approved these changes Apr 23, 2020
View reviewed changes
yoshinorin
yoshinorin previously approved these changes Apr 23, 2020
View reviewed changes
JLHwung
JLHwung reviewed Apr 23, 2020
View reviewed changes
package.json Outdated Show resolved Hide resolved
@curbengh curbengh mentioned this pull request Apr 23, 2020
Closed
2 tasks
@SukkaW SukkaW dismissed stale reviews from yoshinorin, jiangtj, and stevenjoezhang via 2675d83 April 26, 2020 10:26
@SukkaW SukkaW changed the title chore: drop Node.js 8 chore/ci: drop Node.js 8 and add Node.js 14 Apr 26, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.742% when pulling 2675d83 on SukkaW:node-10.0 into c51b87e on hexojs:master.

@SukkaW SukkaW merged commit 687685e into hexojs:master Apr 27, 2020
@SukkaW SukkaW mentioned this pull request Jul 25, 2020
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenjoezhang stevenjoezhang stevenjoezhang approved these changes

@JLHwung JLHwung JLHwung approved these changes

@tomap tomap Awaiting requested review from tomap

@curbengh curbengh Awaiting requested review from curbengh

@dailyrandomphoto dailyrandomphoto Awaiting requested review from dailyrandomphoto

@yoshinorin yoshinorin Awaiting requested review from yoshinorin

@jiangtj jiangtj Awaiting requested review from jiangtj

Assignees
No one assigned
Labels
Breaking Change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop NodeJs 8 support & Require NodeJs >= 10
7 participants
@SukkaW @coveralls @JLHwung @yoshinorin @jiangtj @stevenjoezhang @curbengh