Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(render): Class syntax #3935

Merged
merged 3 commits into from
Dec 15, 2019
Merged

refactor(render): Class syntax #3935

merged 3 commits into from
Dec 15, 2019

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Dec 13, 2019 •
edited by yoshinorin
Loading

What does it do?

Continuation of #3780

How to test

git clone -b render-class https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@curbengh curbengh changed the title Render class refactor(render): Class syntax Dec 13, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 97.134% when pulling 06eeb69 on curbengh:render-class into e4a5292 on hexojs:master.

yoshinorin
yoshinorin approved these changes Dec 14, 2019
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@curbengh curbengh merged commit 0bebf60 into hexojs:master Dec 15, 2019
@curbengh curbengh deleted the render-class branch December 15, 2019 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@curbengh @coveralls @yoshinorin