-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(permalink): pretty_urls.trailing_html #3917
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SukkaW
requested changes
Dec 9, 2019
curbengh
changed the title
refactor(permalink): prettyUrls of hexo-util
feat(permalink): pretty_urls.trailing_html
Dec 9, 2019
SukkaW
previously approved these changes
Dec 10, 2019
curbengh
force-pushed
the
pretty_urls-util
branch
from
December 10, 2019 12:06
fc1fc7a
to
e6955d3
Compare
SukkaW
approved these changes
Dec 10, 2019
This was referenced Dec 12, 2019
Merged
curbengh
pushed a commit
to curbengh/curbengh.github.io
that referenced
this pull request
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Continuation of #3691.
Utilize
prettyUrls()
introduced in hexojs/hexo-util#152 (credit @SukkaW)Supersede #3893
When
pretty_urls.trailing_html
is disabled, permalink likeexample.com/foo/bar.html
is transformed intoexample.com/foo/bar
.The option doesn't apply to url with trailing
index.html
, e.g.example.com/foo/bar/index.html
. I don't thinkexample.com/foo/bar/index/
is valid.How to test
Screenshots
Pull request tasks