-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(open_graph): locale must in language_TERRITORY format #3808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curbengh
changed the title
fix(open_graph): do not add og:locale if lang is en
fix(open_graph): locale must in language_TERRITORY format
Oct 27, 2019
BREAKING CHANGE: og:locale won't be added if language value is not in 'language-territory' format
yoshinorin
reviewed
Oct 29, 2019
SukkaW
previously approved these changes
Nov 2, 2019
Removed |
SukkaW
approved these changes
Nov 2, 2019
SukkaW
added a commit
to SukkaW/hexo-site
that referenced
this pull request
Dec 1, 2019
15 tasks
This was referenced Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Recently tested hexo.io against facebook linter. Apparently, the value for "og:locale" must be in
language_TERRITORY
format, so "en" is invalid. Here is a list of valid values.If
og:locale
is not specified, fb defaults to "en_US".(The following note is only applicable if you're not using en-US locale. It's optional for en-US users.)
If the
language
value (regardless from config or front matter) is not inlanguage-TERRITORY
format, "og:locale" will not be added.If the language value in _config is just two characters (e.g. "en", "fr"), then you need to append territory value, e.g. "en-GB", "fr-CA". you also need to update the filename of the language file (e.g. "en.yml" -> "en-GB.yml") of your theme.
Alternatively, you could also set
<%- open_graph({language: 'en-GB'}) %>
in your theme layout.How to test
Screenshots
Pull request tasks