Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(toc_helper): replace lodash with hexo-util #3786

Merged
merged 1 commit into from
Oct 22, 2019
Merged

refactor(toc_helper): replace lodash with hexo-util #3786

merged 1 commit into from
Oct 22, 2019

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Oct 21, 2019 •
edited
Loading

What does it do?

This PR is a part of #3753

How to test

git clone -b drop-loadsh-for-toc-helper https://github.com/sukkaw/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@SukkaW SukkaW requested review from segayuu and curbengh October 21, 2019 15:00
@SukkaW SukkaW changed the title refactor(toc_helper): relpace lodash with hexo-util refactor(toc_helper): replace lodash with hexo-util Oct 21, 2019
@SukkaW SukkaW force-pushed the drop-loadsh-for-toc-helper branch from b8ee1bf to 68f4303 Compare October 21, 2019 15:01
@coveralls
Copy link

coveralls commented Oct 21, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 97.267% when pulling 68f4303 on SukkaW:drop-loadsh-for-toc-helper into 9ba38e9 on hexojs:master.

@segayuu segayuu merged commit 7e48df3 into hexojs:master Oct 22, 2019
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomap tomap tomap approved these changes

@segayuu segayuu Awaiting requested review from segayuu

@curbengh curbengh Awaiting requested review from curbengh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SukkaW @coveralls @tomap @segayuu