chore: update to [email protected] and [email protected]

[tomap]

I updated both packages to RC versions, and there are a few tests to investigate after the update

[coveralls]

Coverage increased (+0.07%) to 97.223% when pulling dced2ac on tomap:feature/PackageRC into 9b87047 on hexojs:master.

[curbengh]

I can confirm the issue is caused by [email protected] alone.

[email protected] vs [email protected]:

41c86,88
<     "bluebird": "^3.4.0",
---
> 
>     "bluebird": "^3.5.2",
> 
43,46c90,104
<     "cross-spawn": "^4.0.0",
<     "highlight.js": "^9.4.0",
<     "html-entities": "^1.2.0",
<     "striptags": "^2.1.1"
---
> 
>     "cross-spawn": "^6.0.5",
> 
>     "highlight.js": "^9.13.1",
> 
>     "html-entities": "^1.2.1",
> 
>     "striptags": "^3.1.1"
> 

Possible causes: cross-spawn, highlight.js and striptags. I'm testing each dep.

---

Issue not resolved after downgrading deps.

---

Looking through the hexo-util's history, the failure starts from this commit (hexojs/hexo-util@38933b6#diff-e8acc63b1e238f3255c900eed37254b8). The commit allows empty attribute to retain (e.g. class="").

Edit: Submitted fix PR (#3648). Merged into this PR instead.

Still looking for cause of weird line numbering.

---

Line numbering issue is caused by hexojs/hexo-util@ed5cb6e#diff-e8acc63b1e238f3255c900eed37254b8
@segayuu

---

https://github.com/hexojs/hexo-util/blob/ed5cb6ed7fa1391ec12af96092d2c752f5624fc2/lib/highlight.js#L39

numbers += `<span class="line">${firstLine + i}</span><br>`;

Somehow firstLine is treated as a string, thus causing string concatenation, instead of being computed.

Submitted fix PR (hexojs/hexo-util#67).

[curbengh]

There is something wrong with this PR/branch,

package.json
"hexo": "tomap/hexo"

works,

but not

"hexo": "tomap/hexo#feature/PackageRC

$ hexo -v
ERROR Local hexo not found in ~/hexo
ERROR Try running: 'npm install hexo --save'

---

Caused by [email protected], no issue after downgraded to [email protected]. Probably related to hexojs/hexo-util#57 (comment).

---

PR fix hexojs/hexo-util#69

[curbengh]

Somehow hexo-util is still outdated. Testing...
hexo-renderer-marked probably needs to be updated.

---

Pass 🎊

[curbengh]

Pending hexojs/hexo-renderer-marked#107

[curbengh]

Pending hexojs/hexo-renderer-marked#108

[yoshinorin]

Tag cloud color class should migrate to hexo-util.

• Add Color class from tagcloud hexo helper hexo-util#58
• Migrate tag_cloud's color source code to hexo-util #3656

[curbengh]

eea2134 fixes #3656, but pending hexojs/hexo-util#75

hexojs/hexo-util#75 merged, pending to be published hexojs/hexo-util#76.

Published https://www.npmjs.com/package/hexo-util/v/1.0.1 to include hexojs/hexo-util#75

@yoshinorin I think it's ready.

[yoshinorin]

@curbengh
Sorry so late. LGTM