Fix category path when placed on root #1526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes the double slashes (http://site.com//cat1) in the category path, when you configure `category_dir` with '/' or ''
| @@ -30,7 +30,8 @@ module.exports = function(ctx) { | |||
|
|
|||
| Category.virtual('path').get(function() { | |||
| var catDir = ctx.config.category_dir; | |||
| if (catDir[catDir.length - 1] !== '/') catDir += '/'; | |||
| if (catDir === '/') catDir = ''; | |||
| if (catDir.length > 0 && catDir[catDir.length - 1] !== '/') catDir += '/'; | |||
There was a problem hiding this comment.
catDir.length > 0 can be catDir.length.
There was a problem hiding this comment.
what you mean? I know the evaluation is the same, I used explicit comparison for better reading.
Have I remove > 0? If Y, no prob.
There was a problem hiding this comment.
Look like to keep code style?
|
Wondering when this will be merged. We're looking to go live with a site we've converted from Jekyll and we need this to match our existing URLs. |
|
Sorry we are a bit slow in merging the PR. |
|
Merged via 9aca27b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the double slashes (i.e. http://site.com//cat1) in the category path, when you configure
category_dirwith '/' or ''