Skip to content

Commit

Permalink
feat(list_tags): add Schema "keywords" and Microdata "tag" (#3678)
Browse files Browse the repository at this point in the history 
* feat(list_tags): add Schema "keywords" and Microdata "tag"

http://microformats.org/wiki/rel-tag
https://schema.org/keywords

* test(list_tags): add Schema "keywords" and Microdata "tag"
  • Loading branch information
@curbengh @yoshinorin
curbengh authored and yoshinorin committed Aug 27, 2019
1 parent f3e0f5c commit 01eebda
Show file tree
Hide file tree
Showing 2 changed files with 39 additions and 39 deletions.
6 changes: 3 additions & 3 deletions lib/plugins/helper/list_tags.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@ function listTagsHelper(tags, options) {
if (options.amount) tags = tags.limit(options.amount);

if (style === 'list') {
result += `<ul class="${className}-list">`;
result += `<ul class="${className}-list" itemprop="keywords">`;

tags.forEach(tag => {
result += `<li class="${className}-list-item">`;

result += `<a class="${className}-list-link" href="${this.url_for(tag.path)}${suffix}">`;
result += `<a class="${className}-list-link" href="${this.url_for(tag.path)}${suffix}" rel="tag">`;
result += transform ? transform(tag.name) : tag.name;
result += '</a>';

Expand All @@ -47,7 +47,7 @@ function listTagsHelper(tags, options) {
tags.forEach((tag, i) => {
if (i) result += separator;

result += `<a class="${className}-link" href="${this.url_for(tag.path)}${suffix}">`;
result += `<a class="${className}-link" href="${this.url_for(tag.path)}${suffix}" rel="tag">`;
result += transform ? transform(tag.name) : tag.name;

if (showCount) {
Expand Down
72 changes: 36 additions & 36 deletions test/scripts/helpers/list_tags.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ describe('list_tags', () => {
const result = listTags();

result.should.eql([
'<ul class="tag-list">',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/bar/">bar</a><span class="tag-list-count">1</span></li>',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/baz/">baz</a><span class="tag-list-count">2</span></li>',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/foo/">foo</a><span class="tag-list-count">1</span></li>',
'<ul class="tag-list" itemprop="keywords">',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/bar/" rel="tag">bar</a><span class="tag-list-count">1</span></li>',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/baz/" rel="tag">baz</a><span class="tag-list-count">2</span></li>',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/foo/" rel="tag">foo</a><span class="tag-list-count">1</span></li>',
'</ul>'
].join(''));
});
Expand All @@ -50,9 +50,9 @@ describe('list_tags', () => {
}));

result.should.eql([
'<ul class="tag-list">',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/bar/">bar</a><span class="tag-list-count">1</span></li>',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/baz/">baz</a><span class="tag-list-count">2</span></li>',
'<ul class="tag-list" itemprop="keywords">',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/bar/" rel="tag">bar</a><span class="tag-list-count">1</span></li>',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/baz/" rel="tag">baz</a><span class="tag-list-count">2</span></li>',
'</ul>'
].join(''));
});
Expand All @@ -63,9 +63,9 @@ describe('list_tags', () => {
});

result.should.eql([
'<a class="tag-link" href="/tags/bar/">bar<span class="tag-count">1</span></a>',
'<a class="tag-link" href="/tags/baz/">baz<span class="tag-count">2</span></a>',
'<a class="tag-link" href="/tags/foo/">foo<span class="tag-count">1</span></a>'
'<a class="tag-link" href="/tags/bar/" rel="tag">bar<span class="tag-count">1</span></a>',
'<a class="tag-link" href="/tags/baz/" rel="tag">baz<span class="tag-count">2</span></a>',
'<a class="tag-link" href="/tags/foo/" rel="tag">foo<span class="tag-count">1</span></a>'
].join(', '));
});

Expand All @@ -75,10 +75,10 @@ describe('list_tags', () => {
});

result.should.eql([
'<ul class="tag-list">',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/bar/">bar</a></li>',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/baz/">baz</a></li>',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/foo/">foo</a></li>',
'<ul class="tag-list" itemprop="keywords">',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/bar/" rel="tag">bar</a></li>',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/baz/" rel="tag">baz</a></li>',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/foo/" rel="tag">foo</a></li>',
'</ul>'
].join(''));
});
Expand All @@ -89,10 +89,10 @@ describe('list_tags', () => {
});

result.should.eql([
'<ul class="test-list">',
'<li class="test-list-item"><a class="test-list-link" href="/tags/bar/">bar</a><span class="test-list-count">1</span></li>',
'<li class="test-list-item"><a class="test-list-link" href="/tags/baz/">baz</a><span class="test-list-count">2</span></li>',
'<li class="test-list-item"><a class="test-list-link" href="/tags/foo/">foo</a><span class="test-list-count">1</span></li>',
'<ul class="test-list" itemprop="keywords">',
'<li class="test-list-item"><a class="test-list-link" href="/tags/bar/" rel="tag">bar</a><span class="test-list-count">1</span></li>',
'<li class="test-list-item"><a class="test-list-link" href="/tags/baz/" rel="tag">baz</a><span class="test-list-count">2</span></li>',
'<li class="test-list-item"><a class="test-list-link" href="/tags/foo/" rel="tag">foo</a><span class="test-list-count">1</span></li>',
'</ul>'
].join(''));
});
Expand All @@ -103,10 +103,10 @@ describe('list_tags', () => {
});

result.should.eql([
'<ul class="tag-list">',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/foo/">foo</a><span class="tag-list-count">1</span></li>',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/bar/">bar</a><span class="tag-list-count">1</span></li>',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/baz/">baz</a><span class="tag-list-count">2</span></li>',
'<ul class="tag-list" itemprop="keywords">',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/foo/" rel="tag">foo</a><span class="tag-list-count">1</span></li>',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/bar/" rel="tag">bar</a><span class="tag-list-count">1</span></li>',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/baz/" rel="tag">baz</a><span class="tag-list-count">2</span></li>',
'</ul>'
].join(''));
});
Expand All @@ -117,10 +117,10 @@ describe('list_tags', () => {
});

result.should.eql([
'<ul class="tag-list">',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/foo/">foo</a><span class="tag-list-count">1</span></li>',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/baz/">baz</a><span class="tag-list-count">2</span></li>',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/bar/">bar</a><span class="tag-list-count">1</span></li>',
'<ul class="tag-list" itemprop="keywords">',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/foo/" rel="tag">foo</a><span class="tag-list-count">1</span></li>',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/baz/" rel="tag">baz</a><span class="tag-list-count">2</span></li>',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/bar/" rel="tag">bar</a><span class="tag-list-count">1</span></li>',
'</ul>'
].join(''));
});
Expand All @@ -133,10 +133,10 @@ describe('list_tags', () => {
});

result.should.eql([
'<ul class="tag-list">',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/bar/">BAR</a><span class="tag-list-count">1</span></li>',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/baz/">BAZ</a><span class="tag-list-count">2</span></li>',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/foo/">FOO</a><span class="tag-list-count">1</span></li>',
'<ul class="tag-list" itemprop="keywords">',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/bar/" rel="tag">BAR</a><span class="tag-list-count">1</span></li>',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/baz/" rel="tag">BAZ</a><span class="tag-list-count">2</span></li>',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/foo/" rel="tag">FOO</a><span class="tag-list-count">1</span></li>',
'</ul>'
].join(''));
});
Expand All @@ -148,9 +148,9 @@ describe('list_tags', () => {
});

result.should.eql([
'<a class="tag-link" href="/tags/bar/">bar<span class="tag-count">1</span></a>',
'<a class="tag-link" href="/tags/baz/">baz<span class="tag-count">2</span></a>',
'<a class="tag-link" href="/tags/foo/">foo<span class="tag-count">1</span></a>'
'<a class="tag-link" href="/tags/bar/" rel="tag">bar<span class="tag-count">1</span></a>',
'<a class="tag-link" href="/tags/baz/" rel="tag">baz<span class="tag-count">2</span></a>',
'<a class="tag-link" href="/tags/foo/" rel="tag">foo<span class="tag-count">1</span></a>'
].join(''));
});

Expand All @@ -160,9 +160,9 @@ describe('list_tags', () => {
});

result.should.eql([
'<ul class="tag-list">',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/bar/">bar</a><span class="tag-list-count">1</span></li>',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/baz/">baz</a><span class="tag-list-count">2</span></li>',
'<ul class="tag-list" itemprop="keywords">',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/bar/" rel="tag">bar</a><span class="tag-list-count">1</span></li>',
'<li class="tag-list-item"><a class="tag-list-link" href="/tags/baz/" rel="tag">baz</a><span class="tag-list-count">2</span></li>',
'</ul>'
].join(''));
});
Expand Down

0 comments on commit 01eebda

Please sign in to comment.