truncate: fixes handling strings shorter than truncate length #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes handling strings shorter than truncate length With this fix the function truncate is more generic. It handles cases when the string length is shorter than the truncate length in that case omission characters should not be added since they are displaying in full.
amejiarosario
force-pushed
the
truncate-short-strings
branch
from
fe349c2 to
34c0023
Compare
tommy351
added a commit
that referenced
this pull request
Nov 4, 2015
truncate: fixes handling strings shorter than truncate length
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this fix the function truncate is more generic. It handles cases when the string length is shorter than the truncate length in that case omission characters should not be added since they are displaying in full.