fix(highlight): decouple 'wrap' and 'hljs' #138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, enabling
hljs
always disablewrap
, but I noticed that it is actually not necessary. I testedhljs: true
+wrap: true
with darcula theme, code highlighting works fine.Noticed while testing hexojs/hexo#3865
Since enabling
line_number
will also enablewrap
, this behavior doesn't change.With this PR, it is possible to enable both
hljs
andwrap
, so user can usehljs-*
prefix in css classes while wrapping the codeblock in<table>
. This can make upgrading the hljs syntax slightly easier.