fix(isExternal): url parameter can be an internal link #123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just noticed a silent issue.
data
will be a string whenurl
is an internal link, resulting inhost
being assigned asundefined
. when it is "undefined", it won't be used, thanks toWhile current code won't cause any crash, it's a bit unsafe to leave it "undefined" and also could lead to incorrect assumption that
data
is always a URL object.