fix(htmlTag): String() before match() for scalar values (#176)

* toString() before match() for scalar values. * Update lib/html_tag.js Co-Authored-By: Sukka <[email protected]> * Fixed misplaced negation operator Co-authored-by: Sukka <[email protected]>
hexojs · Jan 26, 2020 · 4e7c24e · 4e7c24e
1 parent ddcdc31
commit 4e7c24e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/html_tag.js b/lib/html_tag.js
@@ -25,7 +25,7 @@ function htmlTag(tag, attrs, text, escape = true) {
     if (attrs[i] == null) result += '';
     else {
       if (i.match(regexUrl)
-        || (tag === 'meta' && !attrs[i].match(regexMeta) && Object.values(attrs)[0].match(regexMeta))) {
+        || (tag === 'meta' && !String(attrs[i]).match(regexMeta) && Object.values(attrs)[0].match(regexMeta))) {
         result += ` ${escapeHTML(i)}="${encodeURL(attrs[i])}"`;
       } else if (attrs[i] === true || i === attrs[i]) result += ` ${escapeHTML(i)}`;
       else if (i.match(/srcset$/i)) result += ` ${escapeHTML(i)}="${encSrcset(attrs[i])}"`;

diff --git a/test/html_tag.spec.js b/test/html_tag.spec.js
@@ -151,4 +151,11 @@ describe('htmlTag', () => {
       content: 'bar " baz'
     }).should.eql('<meta name="foo image" content="bar &quot; baz">');
   });
+
+  it('meta tag - numeric property', () => {
+    htmlTag('meta', {
+      property: 'fb:app_id',
+      content: 123456789
+    }).should.eql('<meta property="fb:app_id" content="123456789">');
+  });
 });