Skip to content

Commit

Permalink
Fix sublanguages highlight
Browse files Browse the repository at this point in the history
  • Loading branch information
l-vo committed Aug 11, 2018
1 parent 2b5e282 commit 417592d
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 21 deletions.
23 changes: 2 additions & 21 deletions lib/highlight.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

var hljs = require('highlight.js/lib/highlight');
var hljs = require('highlight.js');
var Entities = require('html-entities').XmlEntities;
var entities = new Entities();
var alias = require('../highlight_alias.json');
Expand Down Expand Up @@ -89,30 +89,11 @@ function replaceTabs(str, tab) {
});
}

function loadLanguage(lang) {
hljs.registerLanguage(lang, require('highlight.js/lib/languages/' + lang));
}

function tryLanguage(lang) {
if (hljs.getLanguage(lang)) return true;
if (!alias.aliases[lang]) return false;

loadLanguage(alias.aliases[lang]);
return true;
}

function loadAllLanguages() {
alias.languages.filter(function(lang) {
return !hljs.getLanguage(lang);
}).forEach(loadLanguage);
}

function highlight(str, options) {
var lang = options.lang;
var autoDetect = options.hasOwnProperty('autoDetect') ? options.autoDetect : false;

if (!lang && autoDetect) {
loadAllLanguages();
lang = (function() {
var result = hljs.highlightAuto(str);
if (result.relevance > 0 && result.language) return result.language;
Expand All @@ -133,7 +114,7 @@ function highlight(str, options) {
return result;
}

if (!tryLanguage(result.language)) {
if (!alias.aliases[result.language]) {
result.language = 'plain';
return result;
}
Expand Down
12 changes: 12 additions & 0 deletions test/scripts/highlight.js
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,18 @@ describe('highlight', function() {
result.should.include('<repository url>');
validateHtmlAsync(result, done);
});

it('highlight sublanguages', function (done) {
var str = '<node><?php echo "foo"; ?></node>';
var result = highlight(str, {lang: 'xml'});
result.should.eql([
'<figure class="highlight xml"><table><tr>',
gutter(1, 1),
code('<span class="tag">&lt;<span class="name">node</span>&gt;</span><span class="php"><span class="meta">&lt;?php</span> <span class="keyword">echo</span> <span class="string">"foo"</span>; <span class="meta">?&gt;</span></span><span class="tag">&lt;/<span class="name">node</span>&gt;</span>', null),
end
].join(''));
validateHtmlAsync(result, done);
});

it('parse multi-line strings correctly', function(done) {
var str = [
Expand Down

0 comments on commit 417592d

Please sign in to comment.