Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test refactor es2016 #67

Merged
merged 4 commits into from
Nov 13, 2018
Merged

Test refactor es2016 #67

merged 4 commits into from
Nov 13, 2018

Conversation

segayuu
Copy link
Contributor

@segayuu segayuu commented Nov 12, 2018

Proposal

The current supported version of hexo-server is 6.9.0 or later, and various grammars of es2016 can be used.
Also, with current error codes, assert missing may occur in promise error handling.
Therefore, we implemented conversion of es2016 by lebab and error handling of promise by chai-as-promised.

@segayuu segayuu requested a review from a team November 12, 2018 02:47
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.495% when pulling be1a4d7 on segayuu:test-refactor-es2016 into aecd99e on hexojs:master.

Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@segayuu segayuu merged commit 9dc9413 into hexojs:master Nov 13, 2018
@segayuu segayuu deleted the test-refactor-es2016 branch November 13, 2018 03:28
@yoshinorin yoshinorin added this to the v0.4.0 milestone Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants