Serve on all interfaces by default #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
reviewed
Nov 9, 2017
lib/server.js
Outdated
| @@ -7,11 +7,12 @@ var Promise = require('bluebird'); | |||
| var format = require('util').format; | |||
There was a problem hiding this comment.
Yes, I switched to the more reliable require('url').format and forgot to remove the format import. I've seen the Travis error: I'll push an update.
This commit changes the default value of the `--ip` option to use Node's internal resolution. It means that it will try to bind to the unspecified IPv6 address `::` if available or else fall back to the unspecified IPv4 address `0.0.0.0`. In most systems, `::` also binds to `0.0.0.0` which effectively allows to listen on all interfaces. Closes hexojs#35
|
The Appveyor issue is due to a version mismatch with Node 9. |
|
Rubberstamp LGTM. |
JLHwung
approved these changes
Nov 9, 2017
|
Any idea about Appveyor? I am not familiar with it. |
|
@demurgos appveyor complains simply because npm 5.5.1 does not officially support nodejs 9.x. As long as test on 8.x is successful, it is safe to merge. |
|
Since it seems fine, I'm merging it. Still, I quickly checked for the Appveyor issue: npm does not seem to use any engine dependency so it's a bit weird. |
demurgos
added a commit
to demurgos/hexo-server
that referenced
this pull request
Dec 22, 2017
This commit is a fix following the PR hexojs#39. This PR changed the default behavior of the server to listen on all interfaces (both IPv4 and IPv6). This commit was missing the update of the default configuration, causing the server to still listen only to IPv4 by default. The current commit fixes this error by using `undefined` (Node's default) for the IP. - See hexojs#35 - See hexojs#39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the default value of the
--ipoption to useNode's internal resolution. It means that it will try to bind to
the unspecified IPv6 address
::if available or else fall back to theunspecified IPv4 address
0.0.0.0. In most systems,::also bindsto
0.0.0.0which effectively allows to listen on all interfaces.Closes #35