Upgrade ejs to v2 (w/ comments support) #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI I just noticed that this is a dupe of #4 |
|
+1, hexo-renderer-ejs2 would be great |
|
@tommy351 As a collaborator at https://github.com/mde/ejs, I'm naturally in favor of this. EJS v1 is totally unmaintained & unsupported. Perhaps hexo-renderer-ejs2 would be a good idea since EJS v2 does break backwards compatibility. |
|
Thank you all. I'm going to create the hexo-renderer-ejs2, which I think is as simple as update the ejs version number. |
|
I have created the EJS v2 renderer for Hexo. https://github.com/NoahDragon/hexo-renderer-ejs2 I close this pull request as the EJS v1 no longer maintained. |
|
The PR has merged, and npm updated accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the dependencies to use the latest ejs v2.3.4, which includes support for comments
<%# ... %>. Also, a unit test was added for comments support (fails with ejs v1).I did some manual smoke testing with a few different themes and did not encounter any issues, but there is still a risk of breaking changes for existing Hexo users:
Feel free to close and ignore this PR if the risk is too great. A
hexo-renderer-ejs2could be created as an alternative, giving users the option to migrate when/if they choose.