Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(eslint): use eslint instead of jscs #10

Merged
merged 2 commits into from
Nov 5, 2018
Merged

chore(eslint): use eslint instead of jscs #10

merged 2 commits into from
Nov 5, 2018

Conversation

yoshinorin
Copy link
Member

Update eslint and delete jscs.
jscs has already merged with eslint. This PR update eslint and it version include merged jscs.

@coveralls
Copy link

coveralls commented Nov 3, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling f8baa74 on YoshinoriN:use-eslint-and-delete-jscs into b7f1f5c on hexojs:master.

@yoshinorin
Copy link
Member Author

yoshinorin commented Nov 3, 2018 •
edited
Loading

@hexojs/core
The CI error problem caused by travis cache. May I disable travis cache in .travis.yml ?

tomap
tomap previously approved these changes Nov 3, 2018
View reviewed changes
Copy link
Contributor

@tomap tomap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoshinorin
chore(ci): delete travisCI cache
f8baa74 
* travis ci has error, caused by cache
@yoshinorin yoshinorin requested a review from a team November 5, 2018 11:07
@yoshinorin
Copy link
Member Author

Thanks @tomap !
I deleted travis CI cache settings. Because, it had error.
I request review one more. Thanks.

tomap
tomap approved these changes Nov 5, 2018
View reviewed changes
Copy link
Contributor

@tomap tomap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated

@yoshinorin yoshinorin merged commit 1740822 into hexojs:master Nov 5, 2018
@yoshinorin
Copy link
Member Author

Thanks !!

@yoshinorin yoshinorin deleted the use-eslint-and-delete-jscs branch November 5, 2018 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomap tomap tomap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yoshinorin @coveralls @tomap