Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup ci (switch to node 14 for coverage and linting) #67

Merged
merged 2 commits into from
Feb 4, 2022
Merged

Cleanup ci (switch to node 14 for coverage and linting) #67

merged 2 commits into from
Feb 4, 2022

Conversation

tomap
Copy link
Contributor

@tomap tomap commented Nov 24, 2021 •
edited
Loading

  • cleanup ci (switch to node 14 for coverage and linting)
  • add dependabot for github actions

@tomap
Switch to picocolors
e3f3465 
nanocolors is deprecated
+ cleanup co (switch to node 14 for coverage and linting)
+ add dependabot for github actions
SukkaW
SukkaW requested changes Nov 24, 2021
View reviewed changes
Copy link
Member

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind splitting changes into 2 PRs? This PR introduces two changes.

Also, just changing package.json only is not enough.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 283adf8 on tomap:nanocolors into 6351236 on hexojs:master.

@tomap tomap changed the title Switch to picocolors Cleanup ci (switch to node 14 for coverage and linting) Jan 8, 2022
@tomap
Copy link
Contributor Author

tomap commented Jan 8, 2022

I used this PR to cleanup ci
Will do another one for nanocolors

@tomap tomap requested a review from SukkaW January 14, 2022 20:06
yoshinorin
yoshinorin approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@tomap tomap merged commit 0efadd5 into hexojs:master Feb 4, 2022
@tomap tomap deleted the nanocolors branch February 4, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

@SukkaW SukkaW Awaiting requested review from SukkaW

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomap @coveralls @yoshinorin @SukkaW