Useful fs.promises API & async / await #53
Conversation
| @@ -511,8 +479,8 @@ function ensureWriteStreamSync(path, options) { | |||
| }); | |||
| }); | |||
|
|
|||
| exports.access = accessAsync; | |||
| exports.accessSync = accessSync; | |||
| exports.access = Promise.promisify(fs.access); | |||
There was a problem hiding this comment.
is Promise.promisify(fs.access) equivalent to fsPromises.access?
There was a problem hiding this comment.
There are two differences between the util.promisify() and Bluebird.promisify() functions.
One is whether the returned promise is a native promise or a bluebird.
The other is that the customization method such as this value and Promise.[[PromiseResult]] is different.
fs.access() has no this value and [[PromiseResult]] is undefined, so there is no difference other than returning Bluebird.
There was a problem hiding this comment.
Meaning util.promisify(fs.access) is equivalent to fsPromises.access?
There was a problem hiding this comment.
There is almost no difference between fs.access() and fs.promises.access() at least in JavaScript implementation (only the line that calls the internal API is different, the implementation of that API is C++).
If node version is 10 or later, fs.promises API and async / await, fs.Dirent are implemented.
While maintaining compatibility, the internal processing has been re-implemented entirely by using the fs.promises API via async / await etc. (As a result, the number of PR rows became large ).