🐛 Fix Min ↔️ Max inversion in DeviceRegistry 😥

This would only impact setups with a high number of devices, but it does make the service quite useless.
hexawyz · Jul 28, 2024 · a025cbd · a025cbd
1 parent 571b9e0
commit a025cbd
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/Exo.Service.Core/DeviceRegistry.cs b/Exo.Service.Core/DeviceRegistry.cs
@@ -597,7 +597,7 @@ public async IAsyncEnumerable<DeviceWatchNotification> WatchAllAsync([Enumerator
 
 		lock (_lock)
 		{
-			initialNotifications = ArrayPool<DeviceWatchNotification>.Shared.Rent(Math.Min(_deviceStates.Count, 10));
+			initialNotifications = ArrayPool<DeviceWatchNotification>.Shared.Rent(Math.Max(_deviceStates.Count, 10));
 			foreach (var state in _deviceStates.Values)
 			{
 				initialNotifications[initialNotificationCount++] = new(WatchNotificationKind.Enumeration, state.GetDeviceStateInformation(), state.Driver);
@@ -655,7 +655,7 @@ public async IAsyncEnumerable<DeviceWatchNotification> WatchAvailableAsync([Enum
 
 		lock (_lock)
 		{
-			initialNotifications = ArrayPool<DeviceWatchNotification>.Shared.Rent(Math.Min(_deviceStates.Count, 10));
+			initialNotifications = ArrayPool<DeviceWatchNotification>.Shared.Rent(Math.Max(_deviceStates.Count, 10));
 			foreach (var state in _deviceStates.Values)
 			{
 				if (state.Driver is not null)
@@ -728,7 +728,7 @@ public async IAsyncEnumerable<DeviceWatchNotification> WatchAllAsync<TFeature>([
 
 		lock (_lock)
 		{
-			initialNotifications = ArrayPool<DeviceWatchNotification>.Shared.Rent(Math.Min(_deviceStates.Count, 10));
+			initialNotifications = ArrayPool<DeviceWatchNotification>.Shared.Rent(Math.Max(_deviceStates.Count, 10));
 			foreach (var state in _deviceStates.Values)
 			{
 				if (state.DeviceInformation.SupportedFeatureIds.Contains(featureId))
@@ -801,7 +801,7 @@ public async IAsyncEnumerable<DeviceWatchNotification> WatchAvailableAsync<TFeat
 
 		lock (_lock)
 		{
-			initialNotifications = ArrayPool<DeviceWatchNotification>.Shared.Rent(Math.Min(_deviceStates.Count, 10));
+			initialNotifications = ArrayPool<DeviceWatchNotification>.Shared.Rent(Math.Max(_deviceStates.Count, 10));
 			foreach (var state in _deviceStates.Values)
 			{
 				if (state.Driver is { } driver && driver.GetFeatureSet<TFeature>() is { IsEmpty: false } featureSet)