Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate wrapper from the main repository, include it as submodule #114

Merged
merged 11 commits into from
Apr 7, 2023

Conversation

heuristicus
Copy link
Owner

@heuristicus heuristicus commented Mar 18, 2023

Prototype to have a unified interface to the SDK which can be used by both the ROS and ROS2 versions. See #113 for more details about that. The wrapper repository can be found at https://github.com/bdaiinstitute/spot_wrapper. See bdaiinstitute/spot_wrapper#1 for details about things which still need to be worked out.

This removes the wrapper from the repository and includes it as a pure python submodule instead. This requires some small modifications to how the repository is installed.

When cloning, it's necessary to run

git submodule init
git submodule update

to make sure the wrapper is pulled in correctly.

It's also necessary to install the wrapper with

pip3 install -e spot_wrapper

This will install the wrapper which should then be available to when running python. The -e flag means that it's installed such that any changes to the files carry over to the installation immediately. Without this it's necessary to install the wrapper every time files change.

Other than this initialisation change, the wrapper should behave as before, but this needs some testing as the wrapper repository is a combination of the ROS1 and ROS2 versions of the wrapper, which had some differences.

@heuristicus heuristicus merged commit b348ecd into master Apr 7, 2023
@heuristicus heuristicus deleted the wrapper-separation branch April 7, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant