Separate wrapper from the main repository, include it as submodule #114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prototype to have a unified interface to the SDK which can be used by both the ROS and ROS2 versions. See #113 for more details about that. The wrapper repository can be found at https://github.com/bdaiinstitute/spot_wrapper. See bdaiinstitute/spot_wrapper#1 for details about things which still need to be worked out.
This removes the wrapper from the repository and includes it as a pure python submodule instead. This requires some small modifications to how the repository is installed.
When cloning, it's necessary to run
to make sure the wrapper is pulled in correctly.
It's also necessary to install the wrapper with
This will install the wrapper which should then be available to when running python. The
-e
flag means that it's installed such that any changes to the files carry over to the installation immediately. Without this it's necessary to install the wrapper every time files change.Other than this initialisation change, the wrapper should behave as before, but this needs some testing as the wrapper repository is a combination of the ROS1 and ROS2 versions of the wrapper, which had some differences.