refactor: do not recurse for request retries #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #412 +/- ##
==========================================
+ Coverage 92.94% 92.95% +0.01%
==========================================
Files 64 64
Lines 2891 2896 +5
==========================================
+ Hits 2687 2692 +5
Misses 204 204 ☔ View full report in Codecov by Sentry. |
jooola
force-pushed
the
refactor-request-method
branch
from
39b71dc to
aee0f23
Compare
jooola
force-pushed
the
refactor-request-method
branch
2 times, most recently
from
f61bb34 to
3efdd34
Compare
jooola
force-pushed
the
refactor-request-method
branch
from
3efdd34 to
d61408d
Compare
apricote
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation work to implement a more advanced retry policy when doing requests.