Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add include_deprecated option when fetching images by name #375

Merged
merged 2 commits into from
Apr 2, 2024
Merged

feat: add include_deprecated option when fetching images by name #375

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4593014
feat: add include_deprecated argument in images get_by_name_and_archi…
jooola Apr 2, 2024
dc2c2a5
force kwargs for include_deprecated arg
jooola Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion hcloud/images/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,16 +317,24 @@ def get_by_name_and_architecture(
self,
name: str,
architecture: str,
*,
include_deprecated: bool | None = None,
jooola marked this conversation as resolved.
Show resolved Hide resolved
) -> BoundImage | None:
"""Get image by name

:param name: str
Used to identify the image.
:param architecture: str
Used to identify the image.
:param include_deprecated: bool (optional)
Include deprecated images. Default: False
:return: :class:`BoundImage <hcloud.images.client.BoundImage>`
"""
return self._get_first_by(name=name, architecture=[architecture])
return self._get_first_by(
name=name,
architecture=[architecture],
include_deprecated=include_deprecated,
)

def update(
self,
Expand Down