feat: remove python-dateutil dependency #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jooola
added a commit
to jooola/hcloud-python
that referenced
this pull request
Jun 30, 2023
This reverts commit 8ea4aa0.
jooola
added a commit
to jooola/hcloud-python
that referenced
this pull request
Jun 30, 2023
This reverts commit 8ea4aa0.
jooola
added a commit
to jooola/hcloud-python
that referenced
this pull request
Jun 30, 2023
This reverts commit 8ea4aa0.
jooola
added a commit
to jooola/hcloud-python
that referenced
this pull request
Jul 3, 2023
This reverts commit 8ea4aa0.
jooola
added a commit
to jooola/hcloud-python
that referenced
this pull request
Jul 3, 2023
This reverts commit 8ea4aa0.
jooola
added a commit
to jooola/hcloud-python
that referenced
this pull request
Jul 3, 2023
This reverts commit 8ea4aa0.
jooola
added a commit
to jooola/hcloud-python
that referenced
this pull request
Jul 3, 2023
This reverts commit 8ea4aa0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested by ansible-collections/hetzner.hcloud#217 (comment)
Remove the python-dateutil dependency, because the python standard library already provides the same features.
isoparse was capable of guessing and parsing different implementation of ISO 8601, but as long as the API provide the same date and time format, datetime.fromisoformat will be able to parse it.