Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deprecate unused window parameter in the EnableBackup call #531

Merged
merged 2 commits into from
Sep 12, 2024
Merged

fix: deprecate unused window parameter in the EnableBackup call #531

merged 2 commits into from
Sep 12, 2024

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Sep 6, 2024

Since the API ignores the backup_window parameter anyway we do not need to send it in requests and can just ignore the variable in Go. This PR also updates the corresponding comment and the tests.

Closes #525

@phm07 phm07 self-assigned this Sep 6, 2024
@phm07 phm07 requested a review from a team as a code owner September 6, 2024 13:02
@codecov Codecov
Copy link

codecov bot commented Sep 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.47%. Comparing base (a90d4c2) to head (d3b89ed).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #531      +/-   ##
==========================================
+ Coverage   71.46%   71.47%   +0.01%     
==========================================
  Files          46       46              
  Lines        3935     3930       -5     
==========================================
- Hits         2812     2809       -3     
+ Misses        710      709       -1     
+ Partials      413      412       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola jooola changed the title fix: remove handling of deprecated backup window parameter and update docs fix: deprecate unused window parameter in the enable_backup call Sep 9, 2024
@jooola jooola changed the title fix: deprecate unused window parameter in the enable_backup call fix: deprecate unused window parameter in the EnableBackup call Sep 9, 2024
@phm07 phm07 merged commit 584f6c2 into main Sep 12, 2024
4 checks passed
@phm07 phm07 deleted the deprecate-backup-window branch September 12, 2024 15:00
@github-actions github-actions bot mentioned this pull request Sep 9, 2024
Merged
jooola pushed a commit that referenced this pull request Oct 21, 2024
@github-actions
chore(main): release 2.14.0 (#524)
09a582a 
🤖 I have created a release *beep* *boop*
---


##
[2.14.0](v2.13.1...v2.14.0)
(2024-10-21)


### Features

* add support for Go 1.23
([#532](#532))
([838f878](838f878))
* allow retrieving the action from an action error
([#538](#538))
([07727d3](07727d3))
* include action ID in action error string
([#539](#539))
([ad5417f](ad5417f))


### Bug Fixes

* deprecate pricing floating ip field
([#523](#523))
([1089d40](1089d40))
* deprecate unused window parameter in the `EnableBackup` call
([#531](#531))
([584f6c2](584f6c2)),
closes [#525](#525)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
apricote pushed a commit to hetznercloud/fleeting-plugin-hetzner that referenced this pull request Oct 21, 2024
@jooola
fix(deps): update module github.com/hetznercloud/hcloud-go/v2 to v2.1…
de5047b 
…4.0 (hetznercloud/fleeting-plugin-hetzner!141)

This MR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/hetznercloud/hcloud-go/v2](https://github.com/hetznercloud/hcloud-go) | require | minor | `v2.13.1` -> `v2.14.0` |

---

### Release Notes

<details>
<summary>hetznercloud/hcloud-go (github.com/hetznercloud/hcloud-go/v2)</summary>

### [`v2.14.0`](https://github.com/hetznercloud/hcloud-go/releases/tag/v2.14.0)

[Compare Source](hetznercloud/hcloud-go@v2.13.1...v2.14.0)

##### Features

-   add support for Go 1.23 ([#&#8203;532](hetznercloud/hcloud-go#532)) ([838f878](hetznercloud/hcloud-go@838f878))
-   allow retrieving the action from an action error ([#&#8203;538](hetznercloud/hcloud-go#538)) ([07727d3](hetznercloud/hcloud-go@07727d3))
-   include action ID in action error string ([#&#8203;539](hetznercloud/hcloud-go#539)) ([ad5417f](hetznercloud/hcloud-go@ad5417f))

##### Bug Fixes

-   deprecate pricing floating ip field ([#&#8203;523](hetznercloud/hcloud-go#523)) ([1089d40](hetznercloud/hcloud-go@1089d40))
-   deprecate unused window parameter in the `EnableBackup` call  ([#&#8203;531](hetznercloud/hcloud-go#531)) ([584f6c2](hetznercloud/hcloud-go@584f6c2)), closes [#&#8203;525](hetznercloud/hcloud-go#525)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMjguNiIsInVwZGF0ZWRJblZlciI6IjM4LjEyOC42IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jooola jooola jooola approved these changes

Assignees

@phm07 phm07

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document removed backup window parameter
2 participants
@phm07 @jooola