fix(ci): race-condition in signing macos binaries #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default the keychain that is used to sign macOS binaries is only unlocked for 300s. This caused the release process to fail, as building all binaries took longer than the 300s, and subsequent signing failed. The new timeout is 3600s (1h), which should be enough to build anything we want. At the moment building all binaries takes ~8m, so we have a buffer of 52m or 650%.
This makes debugging any issues encountered in these steps easier.
In release builds we use `--parallelism=2` and the latest goreleaser version. We should use the same settings in our dev builds.
LKaemmerling
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the keychain that is used to sign macOS binaries is only unlocked for 300s. This caused the release process to fail, as building all binaries took longer than the 300s, and subsequent signing failed.
The new timeout is 3600s (1h), which should be enough to build anything we want. At the moment building all binaries takes ~8m, so we have a buffer of 52m or 650%.
Further changes made here:
fix(ci): show logs of gon hooks
This makes debugging any issues encountered in these steps easier.
fix(ci): use similar goreleaser settings to tagged release builds
In release builds we use
--parallelism=2and the latest goreleaser version. We should use the same settings in our dev builds.