Update workspace resolver version to 3 #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For virtual workspaces (workspaces where there isn't a top level crate, only member crates), there is no top-level Rust `edition` property from which Cargo can infer its resolver version. Instead, one must specify the resolver version explicitly. Now we're using Rust 2024 edition (which defaults to resolver version 3 for crates using that edition), we should update the overall workspace resolver version from 2 to 3 for parity with it. See: https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions GUS-W-17894359.
Malax
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For virtual workspaces (workspaces where there isn't a top level crate, only member crates), there is no top-level Rust
editionproperty from which Cargo can infer its resolver version. Instead, one must specify the resolver version explicitly.Now we're using Rust 2024 edition (which defaults to resolver version 3 for crates using that edition), we should update the overall workspace resolver version from 2 to 3 for parity with it.
See:
https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions
GUS-W-17894359.