Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine tests for handling of invalid app fixture directories #714

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Combine tests for handling of invalid app fixture directories #714

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions libcnb-test/tests/integration_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,20 +239,6 @@ fn app_dir_absolute_path() {
// that only appears in the absolute path, not the relative path passed to `BuildConfig::new`.
#[should_panic(expected = "libcnb-test/tests/fixtures/non-existent-fixture")]
fn app_dir_invalid_path() {
TestRunner::default().build(
BuildConfig::new("heroku/builder:22", "tests/fixtures/non-existent-fixture")
.buildpacks(Vec::new()),
|_| {},
);
}

#[test]
#[ignore = "integration test"]
// The full panic message looks like this:
// `"App dir is not a valid directory: /.../libcnb-test/tests/fixtures/non-existent-fixture"`
// See above for why we only test this substring.
#[should_panic(expected = "libcnb-test/tests/fixtures/non-existent-fixture")]
fn app_dir_invalid_path_checked_before_applying_preprocessor() {
TestRunner::default().build(
BuildConfig::new("heroku/builder:22", "tests/fixtures/non-existent-fixture")
.buildpacks(Vec::new())
Expand Down