Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Remove Scala compiler from libraryDependencies #57

Closed
wants to merge 2 commits into from

Conversation

y-yu
Copy link

@y-yu y-yu commented Sep 12, 2021

  • I cannot use sbt-heroku in Scala 3 project due to this error:
    [info] [error] sbt.librarymanagement.ResolveException: Error downloading org.scala-lang:scala-compiler:3.0.1
    [info] [error]   Not found
    [info] [error]   Not found
    [info] [error]   not found: /Users/yyu/.ivy2/local/org.scala-lang/scala-compiler/3.0.1/ivys/ivy.xml
  • Actually I didn't know why scala-compiler had been added to libraryDependencies 🤔
  • I add Scala 3 + akka-http test
  • Work around:

@y-yu y-yu force-pushed the remove-scala-runtime-dependency branch from bceaf37 to 129f737 Compare September 12, 2021 08:26
@y-yu y-yu changed the title Remove libraryDependencies of Scala runtime Remove Scala compiler from libraryDependencies Sep 12, 2021
@y-yu
Copy link
Author

y-yu commented Sep 12, 2021

How do I do to run CI? 🤔

@xuwei-k
Copy link
Contributor

xuwei-k commented Sep 12, 2021

1bd2bbd
🤔

@y-yu y-yu marked this pull request as ready for review September 16, 2021 14:12
@y-yu y-yu requested a review from a team as a code owner September 16, 2021 14:12
Copy link

@DanielDispatchIT DanielDispatchIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's see if we can get someone to merge the PR. I have the same issue and this fix would be great.

@y-yu
Copy link
Author

y-yu commented Feb 5, 2022

@Malax
Please check Circle CI setting of this repository 🙏

Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'm about to enable review reminder for team-alias reviews, so I'm switching any reviews that need language-owner review to the owner directly, to prevent reminders the rest of the team can't action)

@edmorley edmorley requested a review from Malax April 26, 2022 08:37
@y-yu y-yu force-pushed the remove-scala-runtime-dependency branch 2 times, most recently from 16cb6e5 to 6fef59e Compare April 26, 2022 13:57
@y-yu y-yu force-pushed the remove-scala-runtime-dependency branch from 6fef59e to dbcc2a7 Compare April 29, 2022 06:21
@y-yu
Copy link
Author

y-yu commented Sep 8, 2022

I will remove akka dependencies in test due to the license change: akka/akka#31561 .

@Malax
Copy link
Member

Malax commented Dec 6, 2023

Closing this PR because this repository will be archived. See https://github.com/heroku/heroku-jvm-application-deployer for an alternative CLI to deploy locally compiled Scala applications.

@Malax Malax closed this Dec 6, 2023
@y-yu y-yu deleted the remove-scala-runtime-dependency branch December 6, 2023 16:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants