-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pg:incidents #81
pg:incidents #81
Conversation
@heroku/department-of-data Any feedback on the output? |
My observations:
Beyond that, I AM EXCITE. Glad to see this being pushed through to the finish line. @mattsoldo, @craigkerstiens any thoughts?
|
"12m 13s (ongoing)" On Fri, May 2, 2014 at 11:12 AM, Harold Giménez [email protected]:
|
|
@cyberdelia looks great, but I think just bare "State" doesn't really tell users much. Perhaps we should borrow the copy we use in tickets (or adapt it) as a description? |
@deafbybeheading There no incidents state description in our incidents framework, and our tickets doesn't use incident states (or at least I haven't found anything like that). And the most crypto one is |
end | ||
|
||
def parse_time(time) | ||
Time.parse(time) if time.is_a?(String) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will return nil if time is not a string, that what you want? It would break line 788 maybe
|
This will show the list of incidents that happened on a database, that looks something like that: