Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pg:incidents #81

Merged
merged 1 commit into from
May 8, 2014
Merged

pg:incidents #81

merged 1 commit into from
May 8, 2014

Conversation

cyberdelia
Copy link
Contributor

This will show the list of incidents that happened on a database, that looks something like that:

=== HEROKU_POSTGRESQL_TIM_MAROON_URL

==== 32fc6661-c301-4217-bfd8-6a9dd060f464
Created At: 2014-05-02 10:31 PDT
State:      Human Intervention
Updated At: 2014-05-02 10:31 PDT

==== 63e331a9-780a-4a65-8949-d54975ef0851
Created At: 2014-05-01 14:28 PDT
State:      Resolved
Updated At: 2014-05-01 14:36 PDT

@cyberdelia cyberdelia changed the title first pass at a pg:incidents pg:incidents May 1, 2014
@cyberdelia
Copy link
Contributor Author

@heroku/department-of-data Any feedback on the output?

@hgmnz
Copy link
Contributor

hgmnz commented May 2, 2014

My observations:

  • Showing the UUID is not great UI. Should we introduce sequence numbers, or something more creative like haiku names or something? downstream-forrest-1243, falling-low-523. Or maybe the title just becomes when the thing started, that's an easy change.
  • I don't think updated at is too relevant, but I would like to see Duration. Duration would say ongoing (or similar) when it's still ongoing, and 11 minutes 2 seconds when it has been resolved.
  • We've wanted to do local time zone for a while, but I don't find a practical way to go about it. We still do UTC in other places like pg:info, so I think we should be consistent with that. If we do local time zone, I think it should change everywhere.

Beyond that, I AM EXCITE. Glad to see this being pushed through to the finish line.

@mattsoldo, @craigkerstiens any thoughts?

$ heroku pg:incidents -a tim
=== HEROKU_POSTGRESQL_TIM_MAROON_URL

==== 2014-05-02 10:31 UTC
State:    Human Intervention
Duration: (ongoing)

==== 2014-05-01 14:28 UTC
State:    Resolved
Duration: 12 minutes 3 seconds
$

@pvh
Copy link

pvh commented May 2, 2014

"12m 13s (ongoing)"

On Fri, May 2, 2014 at 11:12 AM, Harold Giménez [email protected]:

My observations:

  • Showing the UUID is not great UI. Should we introduce sequence
    numbers, or something more creative like haiku names or something?
    downstream-forrest-1243, falling-low-523. Or maybe the title just
    becomes when the thing started, that's an easy change.
  • I don't think updated at is too relevant, but I would like to see
    Duration. Duration would say ongoing (or similar) when it's still
    ongoing, and 11 minutes 2 seconds when it has been resolved.
  • We've wanted to do local time zone for a while, but I don't find a
    practical way to go about it. We still do UTC in other places like
    pg:info, so I think we should be consistent with that. If we do local
    time zone, I think it should change everywhere.

Beyond that, I AM EXCITE. Glad to see this being pushed through to the
finish line.

@mattsoldo https://github.com/mattsoldo, @craigkerstienshttps://github.com/craigkerstiensany thoughts?

$ heroku pg:incidents -a tim
=== HEROKU_POSTGRESQL_TIM_MAROON_URL

==== 2014-05-02 10:31 UTC
State: Human Intervention
Duration: ongoing

==== 2014-05-01 14:28 UTC
State: Resolved
Duration: 12 minutes 3 seconds
$


Reply to this email directly or view it on GitHubhttps://github.com//pull/81#issuecomment-42061104
.

@cyberdelia
Copy link
Contributor Author

@hgmnz Great ideas, using UTC makes sense as a title/identifier too.
@pvh Damn, you stole my only idea.

P.S: Local time zone was hard because pg:info data is formatted on the server side, here it's formatted on the client side 😉

@cyberdelia
Copy link
Contributor Author

=== HEROKU_POSTGRESQL_MAROON_URL

==== 2014-05-02 17:31 UTC
Duration: 19 minutes 17 seconds (ongoing)
State:    Human Intervention

==== 2014-05-01 21:28 UTC
Duration: 7 minutes 49 seconds
State:    Resolved

@msakrejda
Copy link
Contributor

@cyberdelia looks great, but I think just bare "State" doesn't really tell users much. Perhaps we should borrow the copy we use in tickets (or adapt it) as a description?

@cyberdelia
Copy link
Contributor Author

@deafbybeheading There no incidents state description in our incidents framework, and our tickets doesn't use incident states (or at least I haven't found anything like that). And the most crypto one is "Await Resolution".

end

def parse_time(time)
Time.parse(time) if time.is_a?(String)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will return nil if time is not a string, that what you want? It would break line 788 maybe

@cyberdelia
Copy link
Contributor Author

=== HEROKU_POSTGRESQL_PURPLE_URL (DATABASE_URL)

==== 2014-04-24 18:20 UTC
Duration: 22 seconds
State:    Archived
Ticket:   https://help.heroku.com/tickets/1111111

==== 2014-04-08 10:18 UTC
Duration: 2 minutes 16 seconds
State:    Archived
Ticket:   https://help.heroku.com/tickets/1111112

==== 2014-02-25 20:26 UTC
Duration: 35 seconds
State:    Archived
Ticket:   https://help.heroku.com/tickets/1111113

==== 2014-02-23 22:37 UTC
Duration: 57 seconds
State:    Archived
Ticket:   https://help.heroku.com/tickets/1111114

==== 2014-02-10 19:51 UTC
Duration: 26 seconds
State:    Archived
Ticket:   https://help.heroku.com/tickets/1111115

==== 2014-02-07 18:24 UTC
Duration: 8 minutes 1 seconds
State:    Archived
Ticket:   https://help.heroku.com/tickets/1111116

==== 2014-02-07 18:04 UTC
Duration: 55 seconds
State:    Archived
Ticket:   https://help.heroku.com/tickets/1111117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants