Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade node and yarn versions #714

Closed
wants to merge 2 commits into from
Closed

Upgrade node and yarn versions #714

wants to merge 2 commits into from

Conversation

josephpage
Copy link
Contributor

@josephpage josephpage commented Feb 28, 2018

Node 8.10.0 is the latest LTS, since node 6.x is near end of its "active" life.
(https://github.com/nodejs/Release)

Yarn 1.5.1 is the latest stable release.
(https://github.com/yarnpkg/yarn/releases)

@hone @schneems @jkutner your reviews are eagerly awaited !

Thanks !


Edited since creation :

  • node from 8.9.4 to 8.10.0 (2018-03-15)

@kfitzpatrick
Copy link

Looks like the HEROKU_API_USER is not set and CI is failing.

Thanks for this patch, I'm really excited to see this updated.

$ bundle exec rake hatchet:setup_travis
== Setting Up Travis ==
rake aborted!
KeyError: key not found: "HEROKU_API_USER"
/home/travis/build/heroku/heroku-buildpack-ruby/vendor/bundle/ruby/2.4.0/gems/heroku_hatchet-3.0.4/lib/hatchet/tasks.rb:9:in `fetch'

@jkutner
Copy link
Contributor

jkutner commented Mar 16, 2018

@josephpage @kfitzpatrick don't worry about the CI failures. It requires a private token that is set on forked PRs (so as to not leak it). We can run the tests locally.

@schneems
Copy link
Contributor

Thanks for the PR! I pushed this to another pr #721 to run tests. Once that is passing I can merge in, after that i'll be able to deploy sometime early next week likely.

schneems added a commit that referenced this pull request Mar 22, 2018
@schneems
Copy link
Contributor

Closed by #721 thanks for the PR!

@schneems schneems closed this Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants