-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 517 Compliant git repos as dependencies, with pipenv, fail install (outdated pip) #979
Comments
FWIW I ended up doing something like this just to get it out, but not sure if you guys are pinning versions or anything else: master...peterhadlaw:214dd67379f322ea392be70824eedfb476154285 |
@peterhadlaw Hi! Thank you for filing this. The current pipenv support has a number of rough edges that are on my list to figure out as new Python owner. We also need to decide long term plans for pipenv support, given the community looks to be wanting to move onto other package managers (eg #921). I likely won't have concrete answers for a while, but will leave this open and update it as I know more. |
For what it's worth, there appear to be signs of life from the
|
Previously the buildpack used pipenv `2018.5.18`, which didn't support newer pip, meaning that apps using pipenv had to be pinned to a much older version of pip. For apps using pipenv, the buildpack now installs pipenv `2020.11.15` and no longer overrides the pip version compared to non-pipenv installs, meaning pip `20.1.1` is now used instead of pip `9.0.2`. Changes: https://github.com/pypa/pipenv/blob/master/CHANGELOG.rst#20201115-2020-11-15 pypa/pipenv@v2018.05.18...v2020.11.15 This is particularly important since the recently released `cryptography` v3.4 requires at least pip 19.x, otherwise pip is unable to use its newer style wheels, and so falls back to building the source distribution. This causes the install to fail, since building `cryptography` now requires Rust, which is not present in the Heroku stack image. Fixes #979. Fixes #987. Fixes #1108. Closes GUS-W-8054805.
Previously the buildpack used pipenv `2018.5.18`, which didn't support newer pip, meaning that apps using pipenv had to be pinned to a much older version of pip. For apps using pipenv, the buildpack now installs pipenv `2020.11.15` and no longer overrides the pip version compared to non-pipenv installs, meaning pip `20.1.1` is now used instead of pip `9.0.2`. (The pip version is still pinned, but to the reasonably new pip version used by all other non-pipenv builds.) Changes: https://github.com/pypa/pipenv/blob/master/CHANGELOG.rst#20201115-2020-11-15 pypa/pipenv@v2018.05.18...v2020.11.15 This is particularly important since the recently released `cryptography` v3.4 requires at least pip 19.x, otherwise pip is unable to use its newer style wheels, and so falls back to building the source distribution. This causes the install to fail, since building `cryptography` now requires Rust, which is not present in the Heroku stack image. Fixes #979. Fixes #987. Fixes #1108. Closes GUS-W-8054805.
Hi! Sorry for the delay in getting this resolved. I've just shipped #1169 for this, and there's a bit more context in: |
Our team uses
pipenv
and up until now it has been working just fine. We now have to import a private git repository that usespoetry
internally and thus does not have asetup.py
defined.I saw in Heroku's blog that
pip
has been upgrade to20
but is there any process to upgrade thepipenv
pathway's version ofpip
as well?pip
>19
supports this, but the version ofpip
forpipenv
environments is still back at9.0.2
python-poetry/poetry#321
and
pypa/pip#5407
The text was updated successfully, but these errors were encountered: