Prune devDependencies for Yarn 2 #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Yarn 2 there is currently no built in support for pruning `devDependencies`. Instead of removing the cache directory entirely and forcing a new install of just the production dependencies, this PR extracts the `devDependencies` from each `package.json` found in the application and calls `yarn remove` to prune them.
joshwlewis
approved these changes
Mar 21, 2022
joshwlewis
approved these changes
Mar 21, 2022
colincasey
added a commit
that referenced
this pull request
Mar 28, 2022
Noticed this was causing CI failures after merging #990. This should get the failing tests sorted.
colincasey
added a commit
that referenced
this pull request
Mar 28, 2022
Noticed this was causing CI failures after merging #990. This should get the failing tests sorted.
colincasey
added a commit
that referenced
this pull request
Mar 30, 2022
There is an issue with the changes to prune the yarn 2 cache that, in certain situations, would cause all devDependencies to be reinstalled during the prune stage which is the opposite result of the intended fix. This can cause slug sizes to increase for customers so this PR restores the previous cache clearing behavior.
colincasey
added a commit
that referenced
this pull request
Mar 30, 2022
Revert changes introduced in #990
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Yarn 2 there is currently no built in support for pruning
devDependencies. Instead of removing the cache directory entirely and forcing a new install for just the production dependencies, this PR extracts thedevDependenciesfrom eachpackage.jsonfound in the application and callsyarn removeto prune them.Fixes #918, GUS-W-9502576