Prefer local packages when present in cache #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the `yarn install` step to use the `--prefer-offline` argument. This avoids reinstalling already-present packages when the local cache has them.
edmorley
reviewed
Aug 31, 2021
joshwlewis
approved these changes
Sep 1, 2021
|
Hi @geoffharcourt -- This looks good to me. Can you add a changelog entry to the unreleased section, so we can get all the checks green here? |
|
@joshwlewis pushed! Thanks for the review. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the
yarn installstep to use the--prefer-offlineargument. This chaneg avoids reinstallingalready-present packages when the local cache has them. Yarn's
default behavior is to attempt to install packages from the network before
falling back to the local cache, which can be unnecessarily time-consuming.
We've been using this change in our buildpack fork for months and it's
improved our build times (we think?) and have not experienced any issues.
Related:
yarnpkg/yarn#6398