Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change node version to 14 #885

Merged
merged 1 commit into from
Jan 14, 2021
Merged

change node version to 14 #885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Node.js Buildpack Changelog

## main
- Update node version to 14 ([#885](https://github.com/heroku/heroku-buildpack-nodejs/pull/885))

# v182 (2020-01-05)
- add Node 14.15.3 and 15.5.0 to inventory ([#881](https://github.com/heroku/heroku-buildpack-nodejs/pull/881))
Expand Down
2 changes: 1 addition & 1 deletion lib/binaries.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ install_yarn() {
}

install_nodejs() {
local version=${1:-12.x}
local version=${1:-14.x}
local dir="${2:?}"
local code os cpu resolve_result

Expand Down
4 changes: 2 additions & 2 deletions test/run
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,8 @@ testYarnRun() {
testNoVersion() {
compile "no-version"
assertCaptured "engines.node (package.json): unspecified"
assertCaptured "Resolving node version 12.x"
assertCaptured "Downloading and installing node 12."
assertCaptured "Resolving node version 14.x"
assertCaptured "Downloading and installing node 14."
assertCapturedSuccess
}

Expand Down