Add checks for Yarn 2 #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielleadams
force-pushed
the
da/detect-yarn-vendor
branch
7 times, most recently
from
3536dc9 to
b5b800d
Compare
danielleadams
force-pushed
the
da/detect-yarn-vendor
branch
2 times, most recently
from
62acf03 to
1565ae0
Compare
danielleadams
force-pushed
the
da/detect-yarn-vendor
branch
from
f203411 to
ef14414
Compare
jkutner
reviewed
Apr 27, 2020
Malax
reviewed
Apr 27, 2020
lib/failure.sh
Outdated
| mcount "failures.missing-yarnrc-yml" | ||
| meta_set "failure" "missing-yarnrc-yml" | ||
| header "Build failed" | ||
| warn "The yarnrc.yml file could not found |
There was a problem hiding this comment.
Nitpick: This is an error, not a warning. Probably suboptimal naming of the logging functions and not related to this PR? This pattern repeats a couple of times in this file.
There was a problem hiding this comment.
Agreed - it makes sense to do some work that lists this as an error with a failure rather than a warn given that one will fail the build and one won't. I'd like to follow up on this outside of this PR.
jkutner
reviewed
Apr 27, 2020
danielleadams
force-pushed
the
da/detect-yarn-vendor
branch
from
40a2f53 to
12a15f9
Compare
|
@lillianzhang331 made your suggested changes too! |
danielleadams
force-pushed
the
da/detect-yarn-vendor
branch
from
12a15f9 to
20cb29c
Compare
danielleadams
force-pushed
the
da/detect-yarn-vendor
branch
from
20cb29c to
d318817
Compare
Malax
approved these changes
Apr 29, 2020
lillianzhang331
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performs checks that look for all the files needed to use Yarn 2 for a build.