update node plugin with v6 and node 13 #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkutner
approved these changes
Dec 4, 2019
jmorrell
reviewed
Dec 4, 2019
There was a problem hiding this comment.
@danielleadams I would also expect updates to:
https://github.com/heroku/heroku-buildpack-nodejs/blob/master/spec/spec_helper.rb#L71
https://github.com/heroku/heroku-buildpack-nodejs/tree/master/spec/fixtures/repos
documented here: https://github.com/heroku/languages-team/blob/master/languages/nodejs/new-major-node-version.md#node-buildpack
| @@ -70,6 +70,10 @@ download_assets_for_release() { | |||
| # Node 12 | |||
| download "https://github.com/heroku/heroku-nodejs-plugin/releases/download/$tag/heroku-nodejs-plugin-node-12-$tag.sha512" "$dir/heroku-nodejs-plugin-node-12.sha512" | |||
| download "https://github.com/heroku/heroku-nodejs-plugin/releases/download/$tag/heroku-nodejs-plugin-node-12-$tag.tar.gz" "$dir/heroku-nodejs-plugin-node-12.tar.gz" | |||
|
|
|||
| # Node 13 | |||
There was a problem hiding this comment.
Note: this isn't ran during the build, but rather this is a script to be run in development. These downloaded files should be checked into the git repo
There was a problem hiding this comment.
Dangit... okay, I need to update these 🙈
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes