Fix downgrade to npm 5.x when using version 10.x or greater #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several checks of the `major` version of npm being used were only accounting for the first character of the version string. E.g.; version `10.1.0` would be treated as `major=1` instead of `major=10`. This PR changes those checks to split on `.` characters using `cut` and read the `major` version as the first field and adds a test to verify. Fixes #1140
sdaicz
reviewed
Sep 21, 2023
schneems
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
I validate it does what is says on the tin. I verified the logic locally:
Before:
$ major_string=10.0 && echo "${major_string:0:1}"
1
$ echo "10.0" | cut -d "." -f 1
10
The only thing I might recommend would be centralizing this logic to a single point of truth like a function that's also more descriptive of the logic we're after. If we want to make that refactor later we could, but it's not necessary for now.
|
@schneems I refactored the logic into a helper function as you suggested. |
joshwlewis
approved these changes
Sep 22, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several checks of the
majorversion of npm being used were only accounting for the first character of the version string. E.g.; version10.1.0would be treated asmajor=1instead ofmajor=10.This PR changes those checks to split on
.characters usingcutand read themajorversion as the first field and adds a test to verify.Fixes #1140