Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates metrics plugins and tests for Node 20 #1087

Merged
merged 4 commits into from
Apr 20, 2023
Merged

Updates metrics plugins and tests for Node 20 #1087

merged 4 commits into from
Apr 20, 2023

Conversation

colincasey
Copy link
Contributor

@colincasey colincasey requested a review from a team as a code owner April 20, 2023 13:52
Malax
Malax approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@Malax Malax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't take a close look at the test fixtures as they look like being copied from an older version, if the answer to my one comment is "yes", ship it! 🚢

plugin/download.sh Outdated Show resolved Hide resolved
@colincasey colincasey enabled auto-merge (squash) April 20, 2023 17:25
@colincasey colincasey merged commit 91cd268 into main Apr 20, 2023
@colincasey colincasey deleted the node-20-metrics branch April 20, 2023 17:51
ostenbom pushed a commit to mentimeter/heroku-buildpack-nodejs that referenced this pull request Sep 11, 2023
@colincasey @ostenbom
Updates metrics plugins and tests for Node 20 (heroku#1087)
82e1057 
* Updates metrics plugins and tests for Node 20

[W-13067131](https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00001Pp1ZpYAJ/view)
@edmorley edmorley mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Malax Malax Malax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colincasey @Malax