Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GOPATH "g" -> "go" #82

Merged
merged 1 commit into from
Jun 1, 2015
Merged

GOPATH "g" -> "go" #82

merged 1 commit into from
Jun 1, 2015

Conversation

austinpray
Copy link
Contributor

closes #81

@austinpray austinpray mentioned this pull request May 31, 2015
@cyx
Copy link

cyx commented May 31, 2015

LGTM. @freeformz ?

@freeformz
Copy link

It's been that way since 46f590b and I'm not sure if it's a typo or not, although it does appear to be one. So LGMT if it works.

@austinpray
Copy link
Contributor Author

It works if I try to provision a blank Ubuntu 14 vagrant box. What do you guys do for testing?

@freeformz freeformz merged commit 00e7102 into heroku:master Jun 1, 2015
@freeformz
Copy link

@austinpray Thanks!. I did some simple testing and it doesn't seem to cause any negative issues, so I merged it.

@austinpray austinpray deleted the patch-1 branch June 1, 2015 16:27
@austinpray
Copy link
Contributor Author

@freeformz if I want to make more significant contributions what process should I follow to verify that it works? If you give me the gist of what process you follow I can perhaps write up a simple contributing.md for posterity.

@freeformz
Copy link

ATM: I have my own fork of the repo and push the branch I want to test to master and then push a test app to heroku using the fork'd buildpack. If everything goes okay, then \o/. There are tests in the repo, but I haven't played much with them yet or understand their coverage yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GOPATH missing "o"
3 participants