Cache stack #58
Merged
Cache stack #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkutner
reviewed
Oct 17, 2019
jkutner
approved these changes
Oct 17, 2019
|
@KevinBrolly Thank you for fixing this! :-) |
|
Published to the buildpack registry: $ heroku buildpacks:publish heroku-community/apt master
Publishing buildpack heroku-community/apt... done
Publishing buildpack was successful
$ heroku buildpacks:versions heroku-community/apt
Version Released At Status
─────── ──────────────────────── ─────────
4 2019-10-17T17:20:09.847Z published
3 2019-09-09T07:26:55.242Z published
2 2019-06-11T06:47:11.497Z published
1 2018-05-21T20:08:40.250Z published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #48 - it adds the current stack to the cache and the bust's the cache if the stack has changed.
I also took the opportunity to refactor the tests and add two new ones for this change. The addition of fixtures should make it easier to add new tests based on different Aptfile configurations in the future.