avoid force-yes with newer version of apt-get #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
force-yes was deprecated with 1.1, and split up into three new options. Keep the same behavior by enabling all 3 options when a newer version is detected. This should fix errors at install time, which are tripping up the current tests.
|
Or maybe it's OK to just always use the new options since Heroku currently supports just the 16.04 and 18.04-based releases, which have apt 1.2 and 1.6 respectively. Happy to redo it the simpler way too. (Actually nevermind - Cedar-14 is EOL but still buildable, and that has 1.0.) |
edmorley
approved these changes
Sep 6, 2019
|
And published to the buildpack registry: |
Closed
EtienneM
pushed a commit
to Scalingo/apt-buildpack
that referenced
this pull request
Dec 16, 2022
force-yes was deprecated with 1.1, and split up into three new options. Keep the same behavior by enabling all 3 options when a newer version is detected. This should fix errors at install time, which are tripping up the current tests. Fixes heroku#16.
taschik
pushed a commit
to obefitness/heroku-buildpack-apt
that referenced
this pull request
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
force-yes was deprecated with 1.1, and split up into three new options.
Keep the same behavior by enabling all 3 options when a newer version is
detected.
This should fix errors at install time, which are tripping up the
current tests.