Experimental interface demonstration #377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's what a function turned into a builder via `bon` would look like
We could take the builder idea to an extreme and allow for BYO functions provided they have the same return type. These would basically be equivalent:
```rust
// Fully spelled out
let _ = cache_layer_builder()
.on_invalid_metadata(&invalid_metadata_action)
.on_restored_layer(&|old, _| restored_layer_action(old, metadata))
.layer_name(layer_name!("ruby"))
.metadata(metadata)
.context(context)
.launch(true)
.build(true)
.call()?;
// With defaults
let layer_ref = cache_layer_builder()
.layer_name(layer_name!("ruby"))
.metadata(metadata)
.context(context)
.call()?;
```
This also allows for skipping writing metadata so it's totally configurable.
If we went this route, we could rename it to something more generic like simply `cache_layer` or maybe `cache_layer_builder`. The module name could be significant, maybe something like `diff_migrate_cache::layer_builder. Naming is hard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR demonstrates using the
boncrate to turn a function into a "builder" using the type/state pattern that can later be called.There are two commits a "simple" and an "advanced" version where everything is customizable.