Bump libcnb from 0.11.1 to 0.11.2 #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [libcnb](https://github.com/heroku/libcnb.rs) from 0.11.1 to 0.11.2. - [Release notes](https://github.com/heroku/libcnb.rs/releases) - [Changelog](https://github.com/heroku/libcnb.rs/blob/main/CHANGELOG.md) - [Commits](heroku/libcnb.rs@v0.11.1...v0.11.2) --- updated-dependencies: - dependency-name: libcnb dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
Fixes:
```
warning: variables can be used directly in the `format!` string
--> buildpacks/jvm/src/errors.rs:36:13
|
36 | format!("Unsupported distribution: {}", distribution),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
note: the lint level is defined here
--> buildpacks/jvm/src/main.rs:3:9
|
3 | #![warn(clippy::pedantic)]
| ^^^^^^^^^^^^^^^^
= note: `#[warn(clippy::uninlined_format_args)]` implied by `#[warn(clippy::pedantic)]`
help: change this to
|
36 - format!("Unsupported distribution: {}", distribution),
36 + format!("Unsupported distribution: {distribution}"),
|
warning: the borrowed expression implements the required traits
--> buildpacks/jvm/src/layers/openjdk.rs:79:17
|
79 | &absolute_jdk_cacerts_path.with_extension("old"),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `absolute_jdk_cacerts_path.with_extension("old")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
warning: variables can be used directly in the `format!` string
--> buildpacks/jvm/src/bin/heroku_dynamic_jvm_opts.rs:27:9
|
27 | format!("{}{}", prefix, suffix),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
note: the lint level is defined here
--> buildpacks/jvm/src/bin/heroku_dynamic_jvm_opts.rs:3:9
|
3 | #![warn(clippy::pedantic)]
| ^^^^^^^^^^^^^^^^
= note: `#[warn(clippy::uninlined_format_args)]` implied by `#[warn(clippy::pedantic)]`
help: change this to
|
27 - format!("{}{}", prefix, suffix),
27 + format!("{prefix}{suffix}"),
|
warning: variables can be used directly in the `format!` string
--> buildpacks/jvm/src/bin/heroku_metrics_agent_setup.rs:33:22
|
33 | let prefix = format!("-javaagent:{}", heroku_metrics_agent_path);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
note: the lint level is defined here
--> buildpacks/jvm/src/bin/heroku_metrics_agent_setup.rs:3:9
|
3 | #![warn(clippy::pedantic)]
| ^^^^^^^^^^^^^^^^
= note: `#[warn(clippy::uninlined_format_args)]` implied by `#[warn(clippy::pedantic)]`
help: change this to
|
33 - let prefix = format!("-javaagent:{}", heroku_metrics_agent_path);
33 + let prefix = format!("-javaagent:{heroku_metrics_agent_path}");
|
warning: variables can be used directly in the `format!` string
--> buildpacks/jvm/src/bin/heroku_metrics_agent_setup.rs:42:13
|
42 | format!("{}{}", prefix, suffix),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
42 - format!("{}{}", prefix, suffix),
42 + format!("{prefix}{suffix}"),
|
warning: `heroku-openjdk` (bin "heroku-openjdk") generated 2 warnings
warning: `heroku-openjdk` (bin "heroku_dynamic_jvm_opts") generated 1 warning
warning: `heroku-openjdk` (bin "heroku_metrics_agent_setup") generated 2 warnings
warning: the borrowed expression implements the required traits
--> buildpacks/maven/src/mode.rs:50:28
|
50 | File::open(&system_properties_path)
| ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `system_properties_path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
warning: the borrowed expression implements the required traits
--> buildpacks/maven/src/main.rs:121:37
|
121 | fs::set_permissions(&maven_wrapper_path, Permissions::from_mode(0o777))
| ^^^^^^^^^^^^^^^^^^^ help: change this to: `maven_wrapper_path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
warning: variables can be used directly in the `format!` string
--> buildpacks/jvm/src/bin/heroku_database_env_var_rewrite.rs:126:13
|
126 | format!("jdbc:{}", url),
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
note: the lint level is defined here
--> buildpacks/jvm/src/bin/heroku_database_env_var_rewrite.rs:3:9
|
3 | #![warn(clippy::pedantic)]
| ^^^^^^^^^^^^^^^^
= note: `#[warn(clippy::uninlined_format_args)]` implied by `#[warn(clippy::pedantic)]`
help: change this to
|
126 - format!("jdbc:{}", url),
126 + format!("jdbc:{url}"),
|
warning: the borrowed expression implements the required traits
--> buildpacks/jvm-function-invoker/src/layers/bundle.rs:90:63
|
90 | let bundle_toml_contents: FunctionBundle = read_toml_file(&bundle_toml_path)
| ^^^^^^^^^^^^^^^^^ help: change this to: `bundle_toml_path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
warning: `maven` (bin "maven") generated 2 warnings
warning: `heroku-openjdk` (bin "heroku_database_env_var_rewrite") generated 1 warning
warning: `jvm-function-invoker-buildpack` (bin "jvm-function-invoker-buildpack") generated 1 warning
warning: `jvm-function-invoker-buildpack` (bin "jvm-function-invoker-buildpack" test) generated 1 warning (1 duplicate)
warning: variables can be used directly in the `format!` string
--> buildpacks/jvm/src/bin/heroku_metrics_agent_setup.rs:67:19
|
67 | Some(&format!("-javaagent:{} {}", AGENT_PATH, JAVA_TOOL_OPTIONS))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
67 - Some(&format!("-javaagent:{} {}", AGENT_PATH, JAVA_TOOL_OPTIONS))
67 + Some(&format!("-javaagent:{AGENT_PATH} {JAVA_TOOL_OPTIONS}"))
|
warning: variables can be used directly in the `format!` string
--> buildpacks/jvm/src/bin/heroku_metrics_agent_setup.rs:82:19
|
82 | Some(&format!("-javaagent:{}", AGENT_PATH))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
82 - Some(&format!("-javaagent:{}", AGENT_PATH))
82 + Some(&format!("-javaagent:{AGENT_PATH}"))
|
warning: `heroku-openjdk` (bin "heroku_metrics_agent_setup" test) generated 4 warnings (2 duplicates)
warning: `heroku-openjdk` (bin "heroku_database_env_var_rewrite" test) generated 1 warning (1 duplicate)
warning: `maven` (bin "maven" test) generated 2 warnings (2 duplicates)
warning: `heroku-openjdk` (bin "heroku-openjdk" test) generated 2 warnings (2 duplicates)
warning: `heroku-openjdk` (bin "heroku_dynamic_jvm_opts" test) generated 1 warning (1 duplicate)
```
Since that's the latest, and is what is used in CI.
edmorley
approved these changes
Jan 2, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps libcnb from 0.11.1 to 0.11.2.
Changelog
Sourced from libcnb's changelog.
Commits
47daf61Prepare 0.11.2 release (#538)2c9c642AddCommandExtfor working withstd::process::Commandoutput streams (#535)39edef1Fix Clippy errors with Rust 1.66/1.67 (#537)dadd5b5Bump Swatinem/rust-cache from 2.1.0 to 2.2.0 (#530)55d9ab9Bump Swatinem/rust-cache from 2.0.2 to 2.1.0 (#528)637ebf9Bump buildpacks/github-actions from 4.8.1 to 4.9.0 (#527)fdff10aBump Swatinem/rust-cache from 2.0.1 to 2.0.2 (#525)484a1f4Update cyclonedx-bom requirement from 0.3.5 to 0.4.0 (#524)c2b931fAlways useSelfwhen referring to self (#518)60b95a0libcnb-test: Check the exit code ofpack sbom download(#520)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)